----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129442/#review100965 -----------------------------------------------------------
Ship it! Please also replace toLatin1() with toLocal8Bit(). - Christoph Feck On Nov. 20, 2016, 2:58 p.m., Tobias Berner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129442/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2016, 2:58 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kiconthemes > > > Description > ------- > > /wrkdirs/usr/ports/x11-themes/kf5-kiconthemes/work/kiconthemes-5.27.0/src/tools/kiconfinder/kiconfinder.cpp:43:55: > error: 'printf' was not declared in this scope > printf("%s\n", icon.toLatin1().constData()); > ^ > > > Diffs > ----- > > src/tools/kiconfinder/kiconfinder.cpp > a9818af94ccaaa9a7ddbd23cc3710c3105ec7ad6 > > Diff: https://git.reviewboard.kde.org/r/129442/diff/ > > > Testing > ------- > > FreeBSD 9.3 i386 (with gcc-4.9) > FreeBSD 12 amd64 (with clang). > > > Thanks, > > Tobias Berner > >
