----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129362/#review100762 -----------------------------------------------------------
code looks good now, but please extend autotests/kwindowinfox11test.cpp with a test method for pid. - Martin Gräßlin On Nov. 10, 2016, 3:30 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129362/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2016, 3:30 p.m.) > > > Review request for KDE Frameworks and Martin Gräßlin. > > > Repository: kwindowsystem > > > Description > ------- > > Allows to retrieve the process ID of the window's application if present. > > > Diffs > ----- > > src/kwindowinfo.h e3dea61 > src/kwindowinfo.cpp e40e397 > src/kwindowinfo_dummy_p.h 933140d > src/kwindowinfo_p.h 7a4ede5 > src/platforms/xcb/kwindowinfo.cpp 3a3fee6 > src/platforms/xcb/kwindowinfo_p_x11.h aeb046a > > Diff: https://git.reviewboard.kde.org/r/129362/diff/ > > > Testing > ------- > > > Thanks, > > Kai Uwe Broulik > >
