> On Oct. 30, 2016, 10:59 p.m., David Faure wrote: > > src/k7zip.cpp, line 2499 > > <https://git.reviewboard.kde.org/r/129170/diff/4/?file=483000#file483000line2499> > > > > Translators (and users) won't know what CTime is, but oh well, not many > > people know anyway ;)
I'm not sure what it is either, which is why I kept the message intact -- same applies to the ATime and MTime error messages. Any idea of a better message? - Romário ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review100413 ----------------------------------------------------------- On Nov. 1, 2016, 8:10 p.m., Romário Rios wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129170/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 8:10 p.m.) > > > Review request for KDE Frameworks. > > > Repository: karchive > > > Description > ------- > > This method is similar to `QIODevice::errorString()`. I added a public > `errorString()` method and a protected `setErrorString()` method, to allow > `KArchive`'s subclasses to implement their own error messages. I also > implemented most error messages from most subclasses. > > > Diffs > ----- > > autotests/karchivetest.cpp d0fbf41 > src/k7zip.h 5b95f49 > src/k7zip.cpp 692b1db > src/kar.h 85bd650 > src/kar.cpp 7204fb1 > src/karchive.h b528a4a > src/karchive.cpp a1a160a > src/karchive_p.h 256620d > src/krcc.h 18c7d00 > src/krcc.cpp 1947dd6 > src/ktar.h 4bca898 > src/ktar.cpp f70b155 > src/kzip.h 84156c7 > src/kzip.cpp 94d4276 > > Diff: https://git.reviewboard.kde.org/r/129170/diff/ > > > Testing > ------- > > I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps > we'll need more tests, but I'm not sure how to make an archive to fail in > some specific way aside from the very basics ("file not found", etc.). > > > Thanks, > > Romário Rios > >
