> On Oct. 27, 2016, 12:57 p.m., Andreas Hartmetz wrote: > > src/ioslaves/file/file.cpp, line 791 > > <https://git.reviewboard.kde.org/r/129259/diff/3/?file=483024#file483024line791> > > > > You can use qMin() here. As is the compiler would complain about the > > different types (off_t and int), which can be fixed by changing the type of > > initialLimit to off_t.
Thanks! But I've noticed that st_size could take a negative value. So I changed to use qBound to determine the initial buffersize. - taro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129259/#review100334 ----------------------------------------------------------- On Oct. 27, 2016, 4:58 a.m., taro yamada wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129259/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 4:58 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 369275 > https://bugs.kde.org/show_bug.cgi?id=369275 > > > Repository: kio > > > Description > ------- > > Currently, KIO uses lstat to get the buffersize for readlink. > But in certain situations, it returns inappropriate value. > > For example, "/proc/self" or "/sys/bus/cpu/devices/*" returns its size is 0 , > and then readlink fails with EINVAL.(so link won't be shown in kde > application.) > TMSU seems it returns its target's actual filesize insted of the link's > filesize itself. > > This patch changes the buffersize to 1024 bytes if it is 0. > And later truncate it to actual size. > > > Diffs > ----- > > src/ioslaves/file/file.cpp 8b17d31 > > Diff: https://git.reviewboard.kde.org/r/129259/diff/ > > > Testing > ------- > > > Thanks, > > taro yamada > >
