----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129236/ -----------------------------------------------------------
(Updated Oct. 26, 2016, 11:53 p.m.) Review request for KDE Frameworks. Changes ------- Added test. Thanks Albert! Repository: kauth Description ------- It was failing because subsequent connects return false. Only try to catch the error if a problem was reported. Declares some enums so they print something when on QDebug. Outputs errors into warnings instead of debug. Removes some tr() string puzzles. Diffs (updated) ----- autotests/HelperTest.cpp 8050a06 src/backends/dbus/DBusHelperProxy.cpp c60def8 src/kauthaction.h 96f550b src/kauthexecutejob.cpp 2901e3b Diff: https://git.reviewboard.kde.org/r/129236/diff/ Testing ------- Now my snap helper can install and then uninstall an application right away. Unit tests pass on my system. Thanks, Aleix Pol Gonzalez
