> On Oct. 25, 2016, 1:37 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't this be in Qt? What am I missing? > > Martin Gräßlin wrote: > Yes it should, but it isn't. No idea why not.
The module is internal, so it intentionally doesn't install any cmake files. - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100257 ----------------------------------------------------------- On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129260/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2016, 1:21 p.m.) > > > Review request for KDE Frameworks, Alex Merry and Martin Gräßlin. > > > Repository: extra-cmake-modules > > > Description > ------- > > Comes from KWin and will eventually be used in Plasma Integration, hence > moving it to extra-cmake-modules. > > > Diffs > ----- > > find-modules/FindQt5PlatformSupport.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129260/diff/ > > > Testing > ------- > > Removed it from KWin, built KWin, worked. > > Built plasma-integration with QDBusMenu private stuff, worked, although > includes there sometimes omit the QtPlatformSupport/ prefix but this is an > upstream issue since it works with the files Kwin includes. > > > Thanks, > > Kai Uwe Broulik > >
