----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129251/ -----------------------------------------------------------
Review request for KDE Frameworks, KDE Usability and Matthew Dawson. Bugs: 357747 https://bugs.kde.org/show_bug.cgi?id=357747 Repository: kconfig Description ------- This patch removes Shift+Del as secondary shortcut for the Cut action. This shortcut was set back in 2001. Reasons for removing it: * The expected standard behavior for this shortcut is "Permanently delete" * For the reason above, it is also set as primary shortcut for the `DeleteFile` action. This causes conflicts in applications. * For the reason above, many applications (e.g. Dolphin or Digikam) already resolve this conflict on their own. Credits to Jan for the investigation: https://bugs.kde.org/show_bug.cgi?id=347373#c2 Diffs ----- src/gui/kstandardshortcut.cpp 92eb091382c7ab2110240cef21f29268be787250 Diff: https://git.reviewboard.kde.org/r/129251/diff/ Testing ------- Using Shift+Del in Gwenview now works as expected. Thanks, Elvis Angelaccio