----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129071/#review99853 -----------------------------------------------------------
Ship it! Oh sorry, I read the sentence "If Gpgmepp is not found, try to use KF5Gpgmepp" as if that meant the new bit was that fallback. Doh. This is a good change then :-) - David Faure On Sept. 29, 2016, 11:32 a.m., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129071/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 11:32 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kwallet > > > Description > ------- > > If Gpgmepp is not found, try to use KF5Gpgmepp > > > Diffs > ----- > > src/runtime/kwalletd/CMakeLists.txt > d7e9ca2c9891db811ecf7063d15f829cf34ad52b > src/runtime/kwalletd/backend/CMakeLists.txt > 20bd4d95c3c1b0cfa43cbe71ce73fa699515ecfa > tests/kwalletd/CMakeLists.txt c84c1db6003412b6a7ac2768f171cbab380b376c > > Diff: https://git.reviewboard.kde.org/r/129071/diff/ > > > Testing > ------- > > Builds and links fine with either GpgME-1.7.0 or KF5Gpgmepp present. > > > Thanks, > > Andreas Sturmlechner > >
