> On Oct. 4, 2016, 8:18 a.m., David Edmundson wrote: > > Is it this? https://bugs.kde.org/show_bug.cgi?id=348414
Sadly I don't think so, i can only reproduce a crash at closing by doing what i say on Testing Done, it may fix it, but i can't prove it. I've looked at the code quite a lot and can't see how that bug would happen tbh. > On Oct. 4, 2016, 8:18 a.m., David Edmundson wrote: > > src/notifybyaudio.cpp, line 156 > > <https://git.reviewboard.kde.org/r/129092/diff/1/?file=481652#file481652line156> > > > > We only want this sound looping check to be in ::onAudioFinished() not > > called from ::close() right, will fix. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129092/#review99754 ----------------------------------------------------------- On Oct. 3, 2016, 9:31 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129092/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 9:31 p.m.) > > > Review request for KDE Frameworks and Martin Klapetek. > > > Repository: knotifications > > > Description > ------- > > Phonon::MediaObject::stop does not emit finished and thus onAudioFinished is > not called and thus finished() was not called and then when closing the app, > the notification manager would go and delete all the non finished > notifications, meaning it would call close() again, add the same > Phonon::MediaObject to m_reusablePhonons again and then crash because it > would delete them twice in the destructor > > > Diffs > ----- > > src/notifybyaudio.h 6726a93 > src/notifybyaudio.cpp 903e996 > > Diff: https://git.reviewboard.kde.org/r/129092/diff/ > > > Testing > ------- > > configure konsole notifications to emit sound on "Bell in Visible Session" > and also show an info box. > > Make it bell and quickly close the info box. > > Close konsole. > > Without this patch it will crash. > > > Thanks, > > Albert Astals Cid > >
