-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128790/
-----------------------------------------------------------

(Updated Oct. 1, 2016, 10:37 a.m.)


Review request for KDE Frameworks, David Faure, Kurt Hindenburg, Oswald 
Buddenhagen, Rex Dieter, and Thiago Macieira.


Changes
-------

Mark UTEMPTER_EXECUTABLE as an advanced CMake variable.


Bugs: 364779
    https://bugs.kde.org/show_bug.cgi?id=364779


Repository: kpty


Description
-------

According to the investigation in https://bugs.kde.org/show_bug.cgi?id=364779 
utempter does stuff in a way that isn't compatible with 
QProcess/KProcess/KPtyProcess (calling sigaction() before launching its child 
process).

So instead we invoke it manually with QProcess.


Diffs (updated)
-----

  cmake/FindUTEMPTER.cmake a3ea06a 
  src/CMakeLists.txt caab96f 
  src/kpty.cpp 15c3b81 
  src/kpty_p.h 192bf1c 

Diff: https://git.reviewboard.kde.org/r/128790/diff/


Testing
-------


Thanks,

Martin Tobias Holmedahl Sandsmark

Reply via email to