> On Sept. 20, 2016, 12:03 a.m., Aleix Pol Gonzalez wrote: > > src/lib/CMakeLists.txt, line 13 > > <https://git.reviewboard.kde.org/r/128951/diff/1/?file=477152#file477152line13> > > > > Use CMAKE_INSTALL_FULL_LOCALSATEDIR instead of > > CMAKE_INSTALL_LOCALSTATEDIR. > > David Edmundson wrote: > I did that at first, but it includes the INSTALL_PREFIX for some weird > reason, setting mine to /opt/kde5/var > > Aleix Pol Gonzalez wrote: > having a leading `/` makes me cringe... :D > Can we report it to upstream cmake at least? It could be interesting to > see how they deal with this for `/etc` which often has the same problem. > > David Edmundson wrote: > After some investigation, cmake has a "feature" whereby if you install to > /usr then FULL_LOCALETSATEDIR is /var for any other prefix it's /prefix/var > > I guess the logic is that if you're installing to another prefix you > probably don't have permissions to install files there. > > I'd rather go with this because I'm always only reading, so the rule > above doesn't apply and I may as well make it work for all devs. > > However, it also implies FULL_STATEDIR will work fine for distros, so I'm > ok with changing. > > Pick one and I'll do that.
We're essentially already hardcoding the path, would it make sense to just hardcode `/var/lib/AccountsService/icons` into the cpp file? It's not like CMake is adding much anyway. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128951/#review99287 ----------------------------------------------------------- On Sept. 19, 2016, 11:56 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128951/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 11:56 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Plasma's UserManager (and Gnome) both now use AccountsService to store > user information. > > AccountsService saves the account information, and more particularly the > avatar, in /var. This is very useful for login managers that need to > load them without having to deal with mounting remote or encrypted home > directories. > > This patch makes KUser return the avatar saved by AccountsService first > if it exist. > > > Diffs > ----- > > src/lib/CMakeLists.txt 437c07e292d4f3e733a6609ddc4b7f8dc3649aab > src/lib/util/config-accountsservice.h.cmake PRE-CREATION > src/lib/util/kuser_unix.cpp 3cb1ee6070f8acba2b090f827eb99c79bf73a77f > > Diff: https://git.reviewboard.kde.org/r/128951/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
