----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128891/#review99107 -----------------------------------------------------------
Ship it! LGTM. Long term I plan to replace all of this with liblmdb++, but that may or may not happen soon-ish. - Boudhayan Gupta On Sept. 12, 2016, 12:21 a.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128891/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 12:21 a.m.) > > > Review request for KDE Frameworks and Boudhayan Gupta. > > > Repository: baloo > > > Description > ------- > > Transaction not created => don't try to abort them, avoid wrong usage of lmdb > api > > > Diffs > ----- > > src/engine/database.cpp 6a433c7 > > Diff: https://git.reviewboard.kde.org/r/128891/diff/ > > > Testing > ------- > > > Thanks, > > Christoph Cullmann > >
