----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128650/ -----------------------------------------------------------
(Updated Sept. 6, 2016, 10:33 p.m.) Review request for KDE Frameworks. Changes ------- Port to QRegularExpression Summary (updated) ----------------- [KBookmarks] Port from QRegExp to QRegularExpression Repository: kbookmarks Description (updated) ------- Kleopatra was crashing on shutdown during cleanup of global statics with QRegExps. Based on [0] I was able to trace the pointer back to .rodata in libKF5KBookmarks.so. This ports to QRegularExpression, which is not affected by the issue explained in [0]. [0] https://blogs.kde.org/2015/11/05/qregexp-qstringliteral-crash-exit Diffs (updated) ----- src/kbookmarkimporter_ie.cpp 7dcbfb3 src/kbookmarkmanager.cpp dd7a98b Diff: https://git.reviewboard.kde.org/r/128650/diff/ Testing ------- Thanks, Daniel Vrátil
