> On Aug. 6, 2016, 10:41 a.m., David Faure wrote: > > The test fails in CI (and locally for me), please fix ;) > > > > https://build.kde.org/view/Frameworks%20kf5-qt5/job/kpackage%20master%20kf5-qt5/88/PLATFORM=Linux,compiler=gcc/testReport/junit/(root)/TestSuite/testfallbackpackage_appstream/ > > > > http://ci-logs.kde.flaska.net/1f/1fdab49485172a5693ecddf48d7640c481e23298/rebuilddep/rebuilddep-kf5-qt57-clang-el7/531a3ae/shell_output.log > > > > Locally: diff -bB > > <src>/kpackage/autotests/data/testfallbackpackage/testfallbackpackage.appdata.xml > > <build>/kpackage/autotests/testfallbackpackage.appdata.xml > > shows that the latter has many more translations, and uses en_GB while the > > former uses en-GB. > > http://www.davidfaure.fr/2016/testfallbackpackage.appdata.diff.txt > > > > To compare XML files, what I did in kdsoap is to put them both into > > QDomDocument and then use toString(), and then compare. It even allows > > showing the actual line of the first difference (while the technique used > > here only shows "files differ"). You can reuse that code, it's LGPL: > > xmlBufferCompare() at > > https://github.com/KDAB/KDSoap/blob/master/testtools/httpserver_p.cpp > > This would help with any sort of formatting issue (indentation, casing of > > "utf-8" etc), but obviously not with the different amount of translations, > > you'd need to remove the translations from the DOM tree first.
For reference, this was referring to a different patch (in KPackage). This change had not been submitted yet. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128533/#review98152 ----------------------------------------------------------- On Aug. 4, 2016, 1:03 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128533/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 1:03 p.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, > Matthias Klumpp, Scarlett Clark, and Harald Sitter. > > > Repository: extra-cmake-modules > > > Description > ------- > > At the moment, we're validating it in build.kde.org, but I feel it will be > easier for developers to test if we do so locally. > This patch does it by seeing which `*.appdata.xml` files are being installed > and validating them. This way we can keep it generic for all KDE projects. > > > Diffs > ----- > > kde-modules/KDECMakeSettings.cmake dd37e7f > kde-modules/appstreamtest.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/128533/diff/ > > > Testing > ------- > > Tested on some projects, locally. > > > Thanks, > > Aleix Pol Gonzalez > >
