----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128661/#review98384 -----------------------------------------------------------
Actually, this is in violation of the current search HIG ( https://community.kde.org/KDE_Visual_Design_Group/HIG/SearchPattern ), but since the de-facto standard in our software and elsewhere is an inline hint, I suppose we should update the HIG. So yes, +1, good change! - Thomas Pfeiffer On Aug. 12, 2016, 8:22 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128661/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 8:22 a.m.) > > > Review request for KDE Frameworks and KDE Usability. > > > Repository: kitemviews > > > Description > ------- > > This makes the search look identical to virtually any other search box used > throughout the workspace. > > > Diffs > ----- > > src/ktreewidgetsearchline.cpp e40a61e > src/ktreewidgetsearchlinewidget.cpp 9af4c2e > > Diff: https://git.reviewboard.kde.org/r/128661/diff/ > > > Testing > ------- > > Tests still pass. > > Looks good. I couldn't figure out how to just create the QLineEdit without > the intermediate QHBoxLayout. > > > File Attachments > ---------------- > > Separate "Search:" label gone > > https://git.reviewboard.kde.org/media/uploaded/files/2016/08/12/c1e2e92d-2113-4d9f-9594-a2e1db0545c2__Screenshot_20160812_102022.png > > > Thanks, > > Kai Uwe Broulik > >
