----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128597/#review98095 -----------------------------------------------------------
This makes no sense. An AppletInterface (which you're emitting the signal for) already has a width and height property. (it does have an x,y, but there're relative to the applet container not the containment) by adding a width and height into the signal applet added you have a potential state where you say "applet added with width 20" and then pass it an object with width 80. That's a broken design. - David Edmundson On Aug. 4, 2016, 10:32 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128597/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 10:32 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > in the addapplet signal, support size paramenters as well, to specify a full > geometry where you want the plasmoid. > > > Diffs > ----- > > src/scriptengines/qml/plasmoid/containmentinterface.h 8236105 > src/scriptengines/qml/plasmoid/containmentinterface.cpp c390ad1 > > Diff: https://git.reviewboard.kde.org/r/128597/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
