> On Aug. 4, 2016, 6:12 a.m., Christoph Feck wrote:
> > src/kmessagebox_p.cpp, line 45
> > <https://git.reviewboard.kde.org/r/128581/diff/2/?file=472930#file472930line45>
> >
> >     If I understand the QGlobalStatic documentation correctly, the 
> > destructor is called after the QApplication object is destroyed.
> >     
> >     Could you please check if it is correct to call 
> > QApplication::instance() and create new objects after this point?

It is "correct", but it will return nullptr.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128581/#review98079
-----------------------------------------------------------


On Aug. 3, 2016, 10:12 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128581/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2016, 10:12 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck, David Faure, and Kevin 
> Ottens.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Otherwise if you don't have the framework integration plugin installed, the 
> messageboxes appear again and again and again even if the user continuously 
> clicks "Don't show again".
> 
> See "KMessageBox runtime dependency on FrameworkIntegrationPlugin makes it 
> useless" thread in kde-frameworks-devel mailing list for more information.
> 
> 
> Diffs
> -----
> 
>   src/kmessagebox_p.cpp 896cdb7 
> 
> Diff: https://git.reviewboard.kde.org/r/128581/diff/
> 
> 
> Testing
> -------
> 
> Tried rsibreak without the framework integration plugin, worked.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to