----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128494/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kio Description ------- slotCancel() isn't called when pressing Esc or closing the window with the window manager button. Doing this the more standard way (reimplementing accept() and reject()) simplifies the code (since KPageDialog sets up the buttonbox this way already) and will be useful for knewfilemenutest which calls accept() on all types of dialog. Diffs ----- src/widgets/kpropertiesdialog.h b451a6ffcb248beb324ef612a0336148c96bccc2 src/widgets/kpropertiesdialog.cpp 808765c706ded7f109719bb2d731692fca0163d8 tests/kpropertiesdialogtest.cpp 7b180608716fa7de0bb2e5221330d0be958ef945 Diff: https://git.reviewboard.kde.org/r/128494/diff/ Testing ------- Looking at the output from kpropertiesdialogtest, to ensure the signals are emitted, and only once. Tested OK, Cancel, Esc, Alt+F4. Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
