----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128451/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kio Description ------- KNameAndUrlInputDialog::url() makes URLs absolute (which is useful in general, for e.g. passing to KIO), so I added urlText() to retrieve the text as is. This removes all the code about showing an error on remote URLs; we just create symlinks to the requested target, whether it looks like "../foo" or "a:/b" which could be a relative path too (although an unusual one). Bug misreported as a comment in bug 352927. Diffs ----- src/filewidgets/knameandurlinputdialog.h c32745d02a1a7361ac35a836cf57d7b9952cc49f src/filewidgets/knameandurlinputdialog.cpp b7a6645874673e998e05ee73a2daef746ce39dd6 src/filewidgets/knewfilemenu.cpp 2e613b19a98587c9a62c9cccf0f8695730798e89 Diff: https://git.reviewboard.kde.org/r/128451/diff/ Testing ------- Created a symlink to "../anotherdir" in konqueror/dolphinpart using "Create New" / "Basic link to file or directory...", the target now stays relative. I looked up who wrote that symlink creation code in order to add him as a reviewer .... turns out the author of commit 8684162 in kde-baseapps is .... me. Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
