----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128232/#review97401 -----------------------------------------------------------
modules/ECMQtDeclareLoggingCategory.cmake (line 72) <https://git.reviewboard.kde.org/r/128232/#comment65729> This is new in Qt5.5 It seems frameworks currently still tries to build against Qt5.4 Either this needs some additional switching or we bump requirements. - David Edmundson On July 13, 2016, 10:22 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128232/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 10:22 p.m.) > > > Review request for Extra Cmake Modules, KDE Frameworks and David Edmundson. > > > Repository: extra-cmake-modules > > > Description > ------- > > The whole point of Info is to be used by apps who want to print out some > info for the user, not disabled by default. > > Example use case: ksmserver could output the name of the autostart > files it's starting, so user can check their own scripts are started, > and associate any errors with the corresponding script. > > In other words: > Debug = debugging for the developer > Info = debugging for the user :-) > > This commit shows the benefit of having a central place for changing this > (many category definitions do not use this macro though) > > > Diffs > ----- > > modules/ECMQtDeclareLoggingCategory.cmake > c125949a46c4b83544413f23d5e04b2d8ea2c4cf > > Diff: https://git.reviewboard.kde.org/r/128232/diff/ > > > Testing > ------- > > The autotests still pass -- somewhat to my surprise ;-) > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
