----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127813/#review97136 -----------------------------------------------------------
Ship it! Looks good to me, thanks. Extending the unittests (KConfigTest::testPath I think) to test for the file:///file%23with%23hash case would be even better, of course. - David Faure On July 4, 2016, 10:36 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127813/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 10:36 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > Don't drop the file: prefix twice in every run. > Use appropriate API on paths rather than string handling, when possible. > > > Diffs > ----- > > src/core/kconfiggroup.cpp 39d2441 > > Diff: https://git.reviewboard.kde.org/r/127813/diff/ > > > Testing > ------- > > Tests pass, apps work. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
