----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128185/#review96479 -----------------------------------------------------------
src/karchive.cpp (line 883) <https://git.reviewboard.kde.org/r/128185/#comment65177> This test doesn't depend on the current file, so it should be done before the for() loop - and if it adjusts curDirName to be destDir (when it would otherwise be outside), this will also fix the other code path (symlink creation). - David Faure On June 14, 2016, 2:01 p.m., Andreas Cord-Landwehr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128185/ > ----------------------------------------------------------- > > (Updated June 14, 2016, 2:01 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: karchive > > > Description > ------- > > Behavior change: Switch to Tar's default behavior to avoid extraction > to arbitrary system locations outside of extraction folder. Instead, > extract such files to root location in extraction folder. > > > Diffs > ----- > > autotests/karchivetest.h 4b7ecff66c9db54239bb2f82cdf0b96e901880ca > autotests/karchivetest.cpp c8abddfc370a283c56766e5a437f3ba69c575563 > src/karchive.cpp 5a7cfc6c92d74c77157dd3fd829eb9b98a90936e > > Diff: https://git.reviewboard.kde.org/r/128185/diff/ > > > Testing > ------- > > See added unit test > > > File Attachments > ---------------- > > test file to be located in autotests/tar_relative_path_outside_archive.tar.bz2 > > https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/3a2388ab-b6a6-4c40-a7c0-083d05be2344__tar_relative_path_outside_archive.tar.bz2 > > > Thanks, > > Andreas Cord-Landwehr > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
