----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128164/ -----------------------------------------------------------
(Updated June 13, 2016, 8:56 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes ------- Submitted with commit cfcb9f757111a55f6aec23ef97a4b5c03e234576 by Martin T. H. Sandsmark to branch master. Bugs: 364253 https://bugs.kde.org/show_bug.cgi?id=364253 Repository: kio-extras Description ------- For consistency when using a QPA that doesn't use KIconLoader, use QIcon instead of KIconLoader for getting the background icon for folder thumbnails. This is visible e. g. in Dolphin when running under a "foreign" session without the plasma-integration QPA: https://bugsfiles.kde.org/attachment.cgi?id=99476 Adding the plasma group to the reviewers, as that was who bugzilla sent to. Diffs ----- thumbnail/thumbnail.cpp f63fe25 Diff: https://git.reviewboard.kde.org/r/128164/diff/ Testing ------- Tried running both without: https://iskrembilen.com/screenshots/withoutplasmaintegration.png and with plasma-integration: https://iskrembilen.com/screenshots/withplasmaintegration.png Thanks, Martin Tobias Holmedahl Sandsmark
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel