> On June 13, 2016, 5:39 a.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 76-78 > > <https://git.reviewboard.kde.org/r/128161/diff/1/?file=468328#file468328line76> > > > > instead of adding a definition could you make it a configure file?
Sure, is that the prefered way? I thought adding a definition is much nicer, as you don't need to care if people forget to include the config...h inside some file and you miss the defines then. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128161/#review96397 ----------------------------------------------------------- On June 12, 2016, 4:55 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128161/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 4:55 p.m.) > > > Review request for KDE Frameworks and Marco Martin. > > > Repository: kdeclarative > > > Description > ------- > > Make epoxy optional instead of just hacking it out for Windows > > This allows to compile this framework e.g. on a Mac without epoxy, too, and > is IMHO saner than just disabling it for Windows. > > > Diffs > ----- > > CMakeLists.txt 42302da > src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 49427aa > src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp fc9d0af > > Diff: https://git.reviewboard.kde.org/r/128161/diff/ > > > Testing > ------- > > Tried it on my mac, now compiles. I have no Linux here ATM, perhaps somebody > can try if it really still works with epoxy around. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
