On Sun, Jun 12, 2016 at 7:51 PM, Albert Astals Cid <aa...@kde.org> wrote:
> Having KMessageBox "dontShowMeAgain" feature depend on an integration > plugin > is a very bad idea. > > Basically it means programs that use KMessageBox can never asusme it will > work > so basically they have to use alternative methods to have the > "dontShowMeAgain" feature or not have it at all. > > I understand someone thought that it was a better idea having a feature > that > may work or not randomly that increasing the dependency chain of > KMessageBox, > but I disagree. > > I don't think the status quo is good at all, my program basically gets a > runtime dependency that is not specified anywhere and that makes some > features > work or not randomly. > > The options I can see are: > * Remove the "dontShowMeAgain" feature from KMessageBox > * Make the "dontShowMeAgain" feature use QSettings (always or if > FrameworkIntegrationPlugin is not available) > * Show a KMessageBox warning when trying to use the "dontShowMeAgain" > feature > and the FrameworkIntegrationPlugin is not available saying the user to > install > that package if he wants to get the functionality. > > Suggestions? > > For those that say this is an hipothetical situation that makes no sense to > fix, please go and read https://bugs.kde.org/show_bug.cgi?id=362082 > > I lost hours of my life trying to figure out what was wrong. > > Cheers, > Albert > _______________________________________________ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > KMessageBox is in KWidgetsAddons which is a tier 1 framework. What you say here would effectively make that framework a Tier 4 library since it does depend on FrameworkIntegration for full functionality. Imho, that's not ideal. Having it use QSettings when not having FrameworkIntegration sounds like a good solution to me.
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
