-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128102/
-----------------------------------------------------------

(Updated jun. 12, 2016, 1:19 a.m.)


Review request for KDE Frameworks, kdelibs, David Faure, and Sune Vuorela.


Repository: kdelibs


Description
-------

Set encoding on kconfig_compiler generated cpp and headers to utf-8 ( 
reproducible builds )

Under certain locals non standard characters will get dropped making builds un 
reproducible. Setting the encoding to utf-8 
on the files makes all builds reproducible no matter what ( or none ) locale is 
in use. Thereby making the build reproducible.


Diffs
-----

  kdecore/kconfig_compiler/kconfig_compiler.cpp 30f52ab1 

Diff: https://git.reviewboard.kde.org/r/128102/diff/


Testing
-------

Built kdelibs then installed it, rebuilt chokoq with patched kdelibs and the 
build is now reproducible. There are likley other kde projects affected and 
will be fixed with this patch.
Thanks for your consideration.


Thanks,

Scarlett Clark

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to