----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128082/#review96164 -----------------------------------------------------------
Ship it! Ship It! - David Faure On June 2, 2016, 7:49 p.m., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128082/ > ----------------------------------------------------------- > > (Updated June 2, 2016, 7:49 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kservice > > > Description > ------- > > As the mimetype name is stored in lowercase in the dictionary, we need to > convert it to lowercase in the dictionary check in > KMimeTypeFactory::serviceOffersOffset() as well. > Otherwise this check always fails if the name contains uppercase characters, > and the list of associated applications will always be empty. > > Problem reported in openSUSE's bugzilla: > http://bugzilla.opensuse.org/show_bug.cgi?id=980046 > > > Diffs > ----- > > src/services/kmimetypefactory.cpp 25a2ce1 > > Diff: https://git.reviewboard.kde.org/r/128082/diff/ > > > Testing > ------- > > Open systemsettings5->File Assocations, create a new mimetype (with uppercase > characters in the name, e.g. application/LabView), add one or more > applications to use for opening that mimetype. > > Now the associated applications are remembered and respected (by dolphin > e.g.), before the list was always empty. > > > Thanks, > > Wolfgang Bauer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
