> On May 26, 2016, 6:14 p.m., Jeremy Whiting wrote: > > Sorry I missed the initial review request somehow. This looks good to me > > except for homepage. Homepage sounds to me like a web site url that gives > > more information about the KNS::Entry. Is that what you're using it for, or > > is it the download url of the asset? If the latter I suggest renaming > > homepage to url or downloadUrl or something more fitting. If the former, it > > looks good to me ship it.
It's the url of the asset. E.g. http://kde-look.org/content/show.php?content=168237 Shipping it. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127997/#review95866 ----------------------------------------------------------- On May 24, 2016, 1:25 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127997/ > ----------------------------------------------------------- > > (Updated May 24, 2016, 1:25 p.m.) > > > Review request for KDE Frameworks and Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > Exposes some API present in either EntryInternal or in Attica::Contents. > > This allows Discover's KNS Backend to just use KNewStuff entries instead of > having to additionally fetch the information in Attica. > > > Diffs > ----- > > src/attica/atticaprovider.cpp 07508b0 > src/core/entryinternal.cpp b05fe24 > src/core/entryinternal_p.h 20f9b1b > src/entry.h 6603e97 > src/entry.cpp 09f9542 > > Diff: https://git.reviewboard.kde.org/r/127997/diff/ > > > Testing > ------- > > Discover works as it used to, with many changes I have locally. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
