----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127843/#review95832 -----------------------------------------------------------
Ship it! Thanks a lot. This now looks good for me (could you remove the one deprecated comment? Besides that, please commit! src/document/katedocument.cpp (line 3119) <https://git.reviewboard.kde.org/r/127843/#comment64848> please delete this comment - Dominik Haumann On May 26, 2016, 1:07 p.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127843/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 1:07 p.m.) > > > Review request for Kate, KDE Frameworks, Christoph Cullmann, and Dominik > Haumann. > > > Repository: ktexteditor > > > Description > ------- > > When using Indic locales composed characters are not properly removed. > Pressing "delete" or "backspace" should remove the entire composed character > and not only one base character. You can see how it should behave when using > another text editor (e.g. libreoffice) > > Can be tested with these words: ?????????? or ??????????? or ???????? > > Technical details: > I'm not really sure whether exporting current text layout is the right way to > do this, I found that this is used when calling moveChar() which moves the > cursor exactly by one composed character so I was trying to find a way to do > it similarly. > > > Diffs > ----- > > autotests/src/katedocument_test.h 8abbad9 > autotests/src/katedocument_test.cpp dd41e0f > src/document/katedocument.cpp 73778a1 > src/view/kateview.h 08db0df > src/view/kateview.cpp fda6b2d > > Diff: https://git.reviewboard.kde.org/r/127843/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
