----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128017/#review95802 -----------------------------------------------------------
+1 From a technical side, it looks good to me (aside from the apidox fix). I don't speak for KXMLGui so I didn't hit Ship It! but the idea and the implementation certainly make sense to me. src/khelpmenu.h (line 235) <https://git.reviewboard.kde.org/r/128017/#comment64825> This needs to have a @since marker. - Michael Pyne On May 25, 2016, 10:55 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128017/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 10:55 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kxmlgui > > > Description > ------- > > Our apps is defined as use our bugzilla for bug reporting. > > > Diffs > ----- > > src/khelpmenu.h df820f2 > src/khelpmenu.cpp 53397cc > src/kxmlguiwindow.cpp b4162c8 > src/ui_standards.rc df9d913 > > Diff: https://git.reviewboard.kde.org/r/128017/diff/ > > > Testing > ------- > > Works, see http://i.imgur.com/iAuLId4.png (well for that you need the other > review i will use since it's kparts, i tried kiriki (regular kxmlgui) and > spectacle (manual khelpmenu) and it works fine) > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
