> On Mayo 15, 2016, 8:34 a.m., David Gil Oliva wrote: > > +1 > > > > Looks ok to me :-)
... when issue is fixed, of course - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127923/#review95477 ----------------------------------------------------------- On Mayo 15, 2016, 8:15 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127923/ > ----------------------------------------------------------- > > (Updated Mayo 15, 2016, 8:15 a.m.) > > > Review request for KDE Frameworks and David Gil Oliva. > > > Repository: kemoticons > > > Description > ------- > > Right now KEmoticonTheme::parse always returns the emoticons > sized by the actual image file size, but there are cases where > different size is needed, for example when parsing emoticons > inline in a text area while typing. > > This also allows to ship bigger emoticon images and have them > scaled down as/when needed. > > > Diffs > ----- > > autotests/kemoticontest.cpp 4e0e539 > src/core/kemoticons.h 4718c00 > src/core/kemoticons.cpp 9756c1f > src/core/kemoticonsprovider.h d259bf8 > src/core/kemoticonsprovider.cpp 5aabd82 > > Diff: https://git.reviewboard.kde.org/r/127923/diff/ > > > Testing > ------- > > Works as expected plus comes with a simple autotest. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
