----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127911/#review95475 -----------------------------------------------------------
Looks good to me. +1 icons/CMakeLists.txt (line 27) <https://git.reviewboard.kde.org/r/127911/#comment64725> Trailing spaces! - Aleix Pol Gonzalez On May 14, 2016, 10:27 a.m., Gleb Popov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127911/ > ----------------------------------------------------------- > > (Updated May 14, 2016, 10:27 a.m.) > > > Review request for KDE Frameworks. > > > Repository: breeze-icons > > > Description > ------- > > I copied icons into the binary dir, because i haven't found a way to generate > rcc without polluting source dir. > > Not sure if installation dir is right, too. > > > Diffs > ----- > > icons/CMakeLists.txt 5ded49c > > Diff: https://git.reviewboard.kde.org/r/127911/diff/ > > > Testing > ------- > > > Thanks, > > Gleb Popov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
