----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127904/#review95453 -----------------------------------------------------------
Ship it! Ship It! - David Faure On May 13, 2016, 12:13 p.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127904/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 12:13 p.m.) > > > Review request for KDE Frameworks, Localization and Translation (l10n) and > David Faure. > > > Repository: kconfigwidgets > > > Description > ------- > > rename directory + adapt docs/CMakeLists.txt > > Rationale: > > Translated docbooks in several frameworks are missing in the tarballs, see > https://todo.kde.org/?controller=task&action=show&task_id=520 > > To find out which subdir of docs/frameworks subdir it should grab translated > docs from, the frameworks release script uses the name of the subdir in the > sources. > > On the other hand the script autogen.sh in l10n-kf5/scripts generates the > CMakeLists.txt files > with the correct install paths/names for the language docbooks using the > dirnames in l10n/[lang]/documentation. > > Now the folder in the sources has a different name than the install name in > the CMakeLists.txt, > in this case dirname "preparetips" != install name "preparetips5". > > Therefore doc/preparetips in kconfigwidgets is pulled into > l10n-kf5/scripts/documentation > with the name preparetips5 using an entry in documentation_paths in > l10n-kf5/scripts > and then processed by scripty and used by translation teams. > > As discussed with David renaming the dirs in the frameworks repos is the > easiest solution and does not require > ugly hacks either in frameworks release script or in autogen.sh. > > Together with commiting this change I'll adapt Scripty. > > Similar changes are required for other frameworks (kdelibs4support, kio, kjs, > kjsembed, kross, kwallet, plasma-framework) as well. > > > Diffs > ----- > > docs/CMakeLists.txt 2c3bd71 > docs/preparetips/CMakeLists.txt 9a16d45 > docs/preparetips/man-preparetips5.1.docbook cb7eee4 > docs/preparetips5/CMakeLists.txt PRE-CREATION > docs/preparetips5/man-preparetips5.1.docbook PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127904/diff/ > > > Testing > ------- > > builds and installs the manpage to the same dir as before > > > Thanks, > > Burkhard Lück > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
