----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127875/ -----------------------------------------------------------
(Updated May 13, 2016, 9:46 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes ------- Submitted with commit fde854c5bed063424e1870e45c2348e09eaca4e6 by Marco Martin to branch master. Repository: kiconthemes Description ------- QIcon has a Selected state that wasn't mapped to KIcon, use it and in case for svg based icons that take colors from the palette take the highlightedText color from the palette to color the icon instead of the text color, making it possible for styles to have white icons and white text in selected menu items (need explicit support from the style, patches in breeze and the like coming) Diffs ----- src/kiconengine.cpp 7c72ade src/kiconloader.h cf2f58a src/kiconloader.cpp 01d0a8d Diff: https://git.reviewboard.kde.org/r/127875/diff/ Testing ------- File Attachments ---------------- menu.png https://git.reviewboard.kde.org/media/uploaded/files/2016/05/09/0fb9a44c-8db4-4a10-91e7-1a6a36e41f62__menu.png Thanks, Marco Martin
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
