-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127805/
-----------------------------------------------------------
Review request for Kate, KDE Frameworks and Christoph Cullmann.
Bugs: 362288
https://bugs.kde.org/show_bug.cgi?id=362288
Repository: ktexteditor
Description
-------
When backup-remote-files is enabled, QUrl::isLocalFile() is used. However,
isLocalFile() also returns true for files that are locally mounted (e.g. nfs,
sshfs, ...).
This patch uses KMountPoint::probablySlow() such that mounted remote files are
also treated as "true" remote files.
However, KMountPoint::probablySlow() right now only checks the filesystem for
nfs, cifs, autofs, or subfs, see:
http://api.kde.org/frameworks-api/apidox-frameworks/frameworks5-apidocs/kio/html/kmountpoint_8cpp_source.html#l00535
So in addition to this patch, we may need to extend KMountPoint::probablySlow()
to also return true for e.g. sshfs or similar common remote filessytems.
When reviewing the patch, please note, that katedocument.cpp also still often
uses QUrl::isLocalFile(). These usages are still correct, afaics.
Diffs
-----
src/document/katedocument.cpp d552b45
Diff: https://git.reviewboard.kde.org/r/127805/diff/
Testing
-------
Compiles.
Thanks,
Dominik Haumann
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
