-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127757/#review94905
-----------------------------------------------------------
Much more elegant than my approach. Only one comment. I missed on place in
ksycocatest.cpp:
--- a/autotests/ksycocatest.cpp
+++ b/autotests/ksycocatest.cpp
@@ -223,7 +223,7 @@ void KSycocaTest::dirTimestampShouldBeCheckedRecursively()
void KSycocaTest::runKBuildSycoca(const QProcessEnvironment &environment, bool
global)
{
QProcess proc;
- const QString kbuildsycoca =
QStandardPaths::findExecutable(KBUILDSYCOCA_EXENAME);
+ const QString kbuildsycoca = QStringLiteral(KBUILDSYCOCAEXE);
QVERIFY(!kbuildsycoca.isEmpty());
QStringList args;
args << "--testmode";
- Jos van den Oever
On apr 27, 2016, 11:38 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127757/
> -----------------------------------------------------------
>
> (Updated apr 27, 2016, 11:38 a.m.)
>
>
> Review request for KDE Frameworks and Jos van den Oever.
>
>
> Repository: kservice
>
>
> Description
> -------
>
> This way we make sure the correct kbuildsycoca is tested.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt 52e7298
> autotests/ksycoca_xdgdirstest.cpp 1aa7140
>
> Diff: https://git.reviewboard.kde.org/r/127757/diff/
>
>
> Testing
> -------
>
> Tests still pass here.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
