----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127743/#review94837 -----------------------------------------------------------
+1 - Aleix Pol Gonzalez On April 25, 2016, 11:02 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127743/ > ----------------------------------------------------------- > > (Updated April 25, 2016, 11:02 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > if the parent directory/ies does not exist yet mkdir would fail even when > technically it could construct the path. > > this in particular occurs in test setups with xvfb&openbox&kded: > - http_jobtest would attempt to talk to the cookiejar > - kded5 gets autostarted & jar loaded > - jar module runs getOrCreate on a path that is relative to a fake home > (e.g. /tmp/kitten-test-123/.local/share/cache > - creation fails > - jar displays dialog that will not ever be run > - test stuck and will time out eventually > - the particular kded used is now defunct > > > Diffs > ----- > > src/ioslaves/http/kcookiejar/kcookieserver.cpp > 9f9d9449b2f06f33ac479b0b5fb47f26c169fb41 > > Diff: https://git.reviewboard.kde.org/r/127743/diff/ > > > Testing > ------- > > tested the at the outlined scenario works > > make test still passes > > > Thanks, > > Harald Sitter > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
