----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127657/#review94648 -----------------------------------------------------------
Ship it! Ship It! - David Faure On April 15, 2016, 8:07 p.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127657/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 8:07 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kparts > > > Description > ------- > > This dialogue is used, e.g. in Konqueror, when asking to open or save the > target of a clicked link. As can be seen from the screen shot, its layout is > squashed due to explicitly setting layout margin and spacing instead of > allowing Qt to use the standard style values. > > This change removes the explicit setting of margin/spacing. > > > Diffs > ----- > > src/browseropenorsavequestion.cpp ce47525 > > Diff: https://git.reviewboard.kde.org/r/127657/diff/ > > > Testing > ------- > > Built kparts with this change, checked appearance and operation of the > dialogue (see screen shot). > > > File Attachments > ---------------- > > Screen shot before > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/15/89690d9d-7868-425b-85b0-c4f9936eaf85__konqueror-openwith-frameworks-breeze-before.png > Screen shot after > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/15/60aa5103-533a-40e9-bc92-f0da3b9b5b3e__konqueror-openwith-frameworks-breeze-after.png > > > Thanks, > > Jonathan Marten > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
