----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kcoreaddons Description ------- KAboutData is passed as values on getting and setting the "applicationData", and it only makes sense to have its properties be a transparent access to the actual mirrored Q*Application metadata. Even more as there is code in KF5 (e.g. KXMLGUI) which relies on KAboutData::applicationData(), without requiring the user to use KAboutData::setApplicationData(). Diffs ----- autotests/kaboutdatatest.cpp f31e7f3 src/lib/kaboutdata.h 97c0f2b src/lib/kaboutdata.cpp ceb0c06 Diff: https://git.reviewboard.kde.org/r/127655/diff/ Testing ------- Added autotests pass. Thanks, Friedrich W. H. Kossebau
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel