----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127380/ -----------------------------------------------------------
(Updated April 7, 2016, 3:18 a.m.) Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Feck. Changes ------- Increase testing by making sure the most adequate icon is chosen at any occasion. Repository: kiconthemes Description ------- My previous approach to KIconThemes felt like a dead end, I decided I'll take a more conservative approach. Here's a first step. Diffs (updated) ----- autotests/CMakeLists.txt 61e81f6 autotests/kiconloader_benchmark.cpp PRE-CREATION autotests/kiconloader_unittest.cpp 0e47cc8 src/kiconloader.cpp 75ab482 src/kicontheme.cpp 0996054 Diff: https://git.reviewboard.kde.org/r/127380/diff/ Testing ------- Attempts to call `KIconThemeDir::iconPath` on the benchmark: 4318 after/5040 before= 17% less QFile::exists Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
