----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126610/#review94076 -----------------------------------------------------------
Do you still have the sample application you made to test/verify this? I'd like to try it and it should probably be committed too. - Stephen Kelly On March 28, 2016, 1:41 p.m., Pino Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126610/ > ----------------------------------------------------------- > > (Updated March 28, 2016, 1:41 p.m.) > > > Review request for KDE Frameworks, David Edmundson and Stephen Kelly. > > > Repository: kitemviews > > > Description > ------- > > When indexes are removed and their widgets deleted, the event filter on each > widget is not removed, leading to the "you should not delete widgets > manually"-alike warning. > > Add an helper forgetAbout() function which performs all the actions done > per-widget before deleting each, additionally removing also the event filter. > > > Diffs > ----- > > src/kwidgetitemdelegate.cpp 779dc2a8a57148fb37f1f5a7194bc9656cb305a4 > src/kwidgetitemdelegatepool.cpp e916dddad8be56bb803e241da43d8cbe7a171ec3 > src/kwidgetitemdelegatepool_p.h 401fe193b0954d6c7c721503d4657b7f08e9fd2e > > Diff: https://git.reviewboard.kde.org/r/126610/diff/ > > > Testing > ------- > > A sample application with widgets for items in the model, removing indexes: > no more warning at removal time. > > > Thanks, > > Pino Toscano > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
