----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127275/#review93158 -----------------------------------------------------------
src/klocalizedstring.cpp (line 349) <https://git.reviewboard.kde.org/r/127275/#comment63522> I would nevertheless ifdef it. It may be that some strange thing is intentionally done with locale variables (e.g. to test something or kill localization), and then the behavior would deviate from that documented for Gettext. - Chusslove Illich On Март 4, 2016, 3:53 по п., Andre Heinecke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127275/ > ----------------------------------------------------------- > > (Updated Март 4, 2016, 3:53 по п.) > > > Review request for KDE Frameworks and Localization and Translation (l10n). > > > Repository: ki18n > > > Description > ------- > > The intention for this patch is to fix the inital Language selection for > Windows where the environment variables used in Ki18n are not set. > This is not a fix for a regression in Ki18n, afaik this never worked on > Windows, we had some hacks in Gpg4win to write the language into kdeglobals > during installation in kde4 times. > > I don't think this needs to be ifdefed because it only appends so previous > language selection is not affected. > > > Diffs > ----- > > src/klocalizedstring.cpp b24fe9b > > Diff: https://git.reviewboard.kde.org/r/127275/diff/ > > > Testing > ------- > > Tested on a german Windows system and got a "de" localized application. > > > Thanks, > > Andre Heinecke > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
