----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127240/#review93001 -----------------------------------------------------------
right, but now with that change we don't need any of the timer stopping changes. - David Edmundson On March 1, 2016, 2:30 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127240/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 2:30 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Rosca, and Marco > Martin. > > > Bugs: 345723 > http://bugs.kde.org/show_bug.cgi?id=345723 > > > Repository: plasma-framework > > > Description > ------- > > Stop timer is any case, if you don't want *this* to be nullptr > > > Diffs > ----- > > src/plasma/private/applet_p.cpp 38d486a > > Diff: https://git.reviewboard.kde.org/r/127240/diff/ > > > Testing > ------- > > Still not tested, but look good for me. > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel