----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127117/#review92625 -----------------------------------------------------------
Looks good, can you get a test case in the PersonsProxyModelTest? - Aleix Pol Gonzalez On Feb. 19, 2016, 9:22 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127117/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 9:22 p.m.) > > > Review request for KDE Frameworks and KDEPIM. > > > Repository: kpeople > > > Description > ------- > > For filtering multiple properties the logic needs to be OR > rather than AND. > > For example in Plasma Mobile, one can start a conversation > either with a phonenumber contact or IM contact, so both > properties need to be requested. But with AND matching it > won't return anything (or only those contacts that have both > and user merged them). > > > Diffs > ----- > > src/personssortfilterproxymodel.cpp b011cbd > > Diff: https://git.reviewboard.kde.org/r/127117/diff/ > > > Testing > ------- > > I get both phonenumber and IM contacts in Plasma Mobile > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
