> On Feb. 12, 2016, 12:02 vorm., Aleix Pol Gonzalez wrote: > > src/kcatalog.cpp, line 179 > > <https://git.reviewboard.kde.org/r/127048/diff/1/?file=444043#file444043line179> > > > > maybe it should be `#ifdef libintl-lite` no?
Also regarding Kare's comment, I will change this to add a CMake option and a corresponding #ifdef that en-/disables use of GNU specific gettext and hence allows compilation with libintl-lite. However, IMO an automatic switch between the different libintl variants would be nice, but currently I do not see if I can check for the exported "_nl_msg_cat_cntr" via CMake. If anyone has an idea I would very welcome it, since that would get us rid of an extra option. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/#review92280 ----------------------------------------------------------- On Feb. 11, 2016, 7:11 nachm., Andreas Cord-Landwehr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127048/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 7:11 nachm.) > > > Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich. > > > Repository: ki18n > > > Description > ------- > > On Android, we do not have libintl but only libintl-lite, which does > not provide _nl_msg_cat_cntr. Actually, _nl_msg_cat_cntr is a GNU > gettext specific tool to prevent wrong localization after runtime language > changes. Thus, it is tied to the specific GNU gettext implementation. > > > Diffs > ----- > > src/kcatalog.cpp 095a6beec721729537a89214a1fbdb661fbfb548 > > Diff: https://git.reviewboard.kde.org/r/127048/diff/ > > > Testing > ------- > > Tested compilation on Android and Linux. > > > Thanks, > > Andreas Cord-Landwehr > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
