----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127031/#review92245 -----------------------------------------------------------
src/lib/kcoreaddons.h (line 29) <https://git.reviewboard.kde.org/r/127031/#comment62921> Documntation is missing Also "technically" one could mix and max versions even if we don't do it nor support it, but maybe we could call it just version() so it would be KCoreAddons::version() which give us a clear indication that in a world of mix & match this may b different frm KXMLGUI::version() (if it existed) Or am i overthinking this? - Albert Astals Cid On Feb. 10, 2016, 5:10 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127031/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 5:10 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Adds a method similar to qVersion() that returns a string of the > frameworks version being run. This differs from the header file which > can only provide the version this app is compiled against. > > The intended usage is in drkonqi system information. > > > Diffs > ----- > > src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 > src/lib/kcoreaddons.h PRE-CREATION > src/lib/kcoreaddons.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127031/diff/ > > > Testing > ------- > > See https://git.reviewboard.kde.org/r/127032/ > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
