----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126650/#review92227 -----------------------------------------------------------
Are we convinced that KIdleTime is the best place to put this? KIdleTime definition is: > KIdleTime is a singleton reporting information on idle time. It is useful not > only for finding out about the current idle time of the PC, but also for > getting notified upon idle time events, such as custom timeouts, or user > activity. Which I'm not sure is the same. Furthermore, KIdleTime is supposed to be crossplatform. src/inhibition.cpp (line 38) <https://git.reviewboard.kde.org/r/126650/#comment62912> move all as initializers? src/inhibition.cpp (line 61) <https://git.reviewboard.kde.org/r/126650/#comment62913> A bunch of these can be marked as const. src/inhibition.cpp (line 94) <https://git.reviewboard.kde.org/r/126650/#comment62914> If this has to be cross-platform, dbus usage should be abstracted out. On Windows/OS X one won't find a dbus interface with this information. - Aleix Pol Gonzalez On Jan. 26, 2016, 7:13 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126650/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 7:13 p.m.) > > > Review request for KDE Frameworks and Kai Uwe Broulik. > > > Repository: kidletime > > > Description > ------- > > This is a work-in-progress, but I'm putting it up for a feedback now > as most people are gone for the day when I wake up :) > > --- > > After some discussion in https://git.reviewboard.kde.org/r/126627/ > and then with Kai Uwe Broulik, I've added a PM/ScreenSaver inhibition > capabilities to KIdleItem. > > We decided with Kai that we want simple stuff, encapsulated away for > the client as much as possible. So the Inhibition class has a static > "constructors" which make the usage as easy as follows: > > KIdleTime::Inhibition::createInhibition(KIdleTime::Inhibition::InhibitScreen, > QStringLiteral("Playing Movie"), mainWindow); > > That call would return an Inhibition* object which has methods to set > the inhibition type and reason and to activate/deactivate the inhibition. > The static method above would activate() on the Inhibition right away; > this allows a simple fire-and-forget usage. The Inhibition object can > be parented to any other object; the inhibition will be deactivated when > the Inhibition object is destroyed. The user can also keep the pointer > around and call deactivate() whenever actually needed. > > The inhibition itself first looks for Solid and if present, it uses the > Solid interface. If not present, it goes for the FDO interfaces. > > It comes with an autotest. > > > Diffs > ----- > > CMakeLists.txt ed5dc0c > autotests/CMakeLists.txt PRE-CREATION > autotests/fakePMServer.h PRE-CREATION > autotests/fakePMServer.cpp PRE-CREATION > autotests/inhibition_test.cpp PRE-CREATION > autotests/qtest_dbus.h PRE-CREATION > src/CMakeLists.txt 23e5e29 > src/inhibition.h PRE-CREATION > src/inhibition.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126650/diff/ > > > Testing > ------- > > Everything works as expected, plus there's an autotest. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
