----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126945/#review91941 -----------------------------------------------------------
Ship it! A couple of nit-picks: - kactivities reviews should go via phabricator in the future - kactivities are in the process of repository splitting, the repository for this patch will be kde:kactivitymanagerd (I'll apply it to the repository when you push this) - Ivan Čukić On Feb. 2, 2016, 12:11 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126945/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 12:11 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 357435 > http://bugs.kde.org/show_bug.cgi?id=357435 > > > Repository: kactivities > > > Description > ------- > > This is dangerous and leads to crashes as the QML processing still > continues in the new event loop. > > Besides, one should never block the plasmashell UI anyway. > > Also as far as I can see, no-one deleted the exec'd dialog and so it was > leaking memory too. > > BUG: 357435 > > > Diffs > ----- > > src/workspace/settings/imports/activitysettings.cpp > e673ec4950f34eaca91e06f410a69e125ef4faee > > Diff: https://git.reviewboard.kde.org/r/126945/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
