----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/#review91906 -----------------------------------------------------------
Ship it! Having custom lib loading code is not a good idea when there's libraries that do that for you. - Albert Astals Cid On Feb. 1, 2016, 7:37 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126948/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 7:37 p.m.) > > > Review request for KDE Frameworks. > > > Repository: attica > > > Description > ------- > > Just use QPluginLoader instead of doing it locally (and with an awkward > blocking QProcess call) > > > Diffs > ----- > > src/providermanager.cpp 0536a1f > > Diff: https://git.reviewboard.kde.org/r/126948/diff/ > > > Testing > ------- > > Test still passes, initializing attica still finds the right plugin on my > system. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
