> On 2月 1, 2016, 8:18 p.m., David Faure wrote: > > Ship It!
Thanks! Sorry, I pushed this commit to remote another branch 'origin/kcoredir' Could you delete this branch? - Takahiro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126892/#review91842 ----------------------------------------------------------- On 2月 2, 2016, 1:34 a.m., Takahiro Hashimoto wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126892/ > ----------------------------------------------------------- > > (Updated 2月 2, 2016, 1:34 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 358723 > https://bugs.kde.org/show_bug.cgi?id=358723 > > > Repository: plasma-workspace > > > Description > ------- > > The createWizardEntry() can return bool value to know if geting correct URL > of new network folder(launching knetattach) failed. > Due to the another bug(i'll send a patch for it), a blank entry is inserted > to the UDSEntry list and cause to crash app (dolphin, gwenview and others > using kcoredirlister) by clicking 'Network' in their placetree view. The > empty UDS_NAME is not permmited. > > This fixes the bug by handling result of createWizardEntry(). > > > Diffs > ----- > > kioslave/remote/kio_remote.cpp ffee08c > > Diff: https://git.reviewboard.kde.org/r/126892/diff/ > > > Testing > ------- > > Confirmed to working fine with dolphin and gwenview (click 'Network' tree) > And checked that no blank UDS_NAME in their placetree view. > > kioslave/remote/tests/testremote has been passed. > > > Thanks, > > Takahiro Hashimoto > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
